-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HandleAllocator is unsafe #284
Comments
robdockins
added a commit
that referenced
this issue
Jul 17, 2019
Update to use safe nonces. fixes #284
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The HandleAllocator type uses the
Data.Parameterized.Nonce.Unsafe
interface which can cause programs to have unsafe memory behavior if more than one handle allocator is created.We should transition
FunctionHandle
module to use theglobalNonceGenerator
from "Data.Parameterized.Nonce" instead. This would have the additional, very convenient, side effect that we wouldn't need to pass HandleAllocator values around anymore, as creating fresh handles could simply use the globally available nonce generator instead.The text was updated successfully, but these errors were encountered: