Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #4924
reference to some improvements made but i'll list them here anyways as a formality.
1: most top-level modules like
module_metadata
,module_iso19115_2
, andmodule_metadata_info
always return a hash. low-level modules likemodule_date
,module_citation
, andmodule_responsibility
occur nested within a document and either return nil when the root element can't be found or the hash as it could be processed.2: i throw a structure error message either when the input document is empty or it's not well formed xml. all other warnings are validation messages.
3: this is implemented. each module will try to gather as much information as possible without returning nil on the first warning.
4: nilreason check is implemented for required elements. it's not implemented for optional.
6: this relates to nilreason.
here's some general improvements
_2_datagov
branch for now.gmd:westBoundLongitude/gco:Decimal
togmd:westBoundLongitude
). the reason is thatgmd:westBoundLongitude
is what's checked for the nilreason.full translate test