Fix Multi GPU Rendering Mode #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AlexanderVeselov
commented
Jul 20, 2018
AlexanderVeselov
commented
- Fix data race when one thread used to drop dirty flags and the others didn't recompile the scene;
- Fix data race when a slower thread sent non-actual information after scene update;
- Fix crash with mgpu config and enabled denoiser;
- Add showing all devices in the gui and add accounting samples from worker threads.
that would be sent from a worker device
o Replace bool m_dirty to std::uint32_t in Baikal::SceneObject o Each scene controller checks&resets corresponding bit in dirty mask + Add Scene1::Acquire and Scene1::Release methods that use mutex to prevent data race when compiling a scene o Fix multipass AOV crash when using mgpu config
o Fix gui to show multiple devices o Fix sample counter to account samples from worker threads o Fix ConfigManager::CreateConfigs when it used to force disable interop even if we have interop device in mgpu o Fix crash on exit with enabled denoiser and mgpu + Add thread join to AppClRender::StopRenderThreads
o Fix signed-unsigned comparison error
o Use std::bitset instead of std::uint32_t for dirty mask o Fix asserts
+ Add comments + Add empty lines o Change variable names
o Replace CL_INVALID_GL_SHAREGROUP_REFERENCE_KHR to explicit error code (-1000)
dtarakanov1
reviewed
Aug 2, 2018
| ConfigManager::CreateConfigs(settings.mode, false, m_cfgs, settings.num_bounces, settings.platform_index, settings.device_index); | ||
| } | ||
| // Create cl context | ||
| ConfigManager::CreateConfigs( |
There was a problem hiding this comment.
CreateConfigs might return std::vector by value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.