lgc: cmake func for adding LLVM external projects #2600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test summary for commit 73dbf4dCTS tests (Failed: 0/211360)
Rhel 9.0, Gfx10Ubuntu 22.04, Navi3xUbuntu 20.04, Navi2x |
nhaehnle
previously approved these changes
Jul 21, 2023
llpc/CMakeLists.txt
Outdated
| set(LLVM_EXTERNAL_LLVM_DIALECTS_SOURCE_DIR ${PROJECT_SOURCE_DIR}/../imported/llvm-dialects) | ||
| set(LLVM_EXTERNAL_LGC_SOURCE_DIR ${PROJECT_SOURCE_DIR}/../lgc) | ||
| # Add LGC and its dependencies as LLVM external projects. | ||
| include("${CMAKE_CURRENT_SOURCE_DIR}/../cmake/lgc.cmake") |
There was a problem hiding this comment.
Is the CMAKE_CURRENT_SOURCE_DIR really necessary?
73dbf4d
to
9891167
Compare
LGC is an LLVM external project, and thus cmake variables need to be set up to tell LLVM about it. Now that it is gaining dependencies that are themselves LLVM external projects (llvm-dialects, LgcCps), this gives a single place to update the cmake variable setting up. This commit introduces: * cmake/lgc.cmake provides add_lgc_projects to add LGC and its dependencies.
9891167
to
d72faaf
Compare
|
Rebased to resolve conflicts and removed unnecessary CMAKE_CURRENT_SOURCE_DIRs. |
It should not be like that, but I will not try and fix that here.
54b3776
to
ed96341
Compare
Test summary for commit ed96341CTS tests (Failed: 0/211876)
Rhel 9.0, Gfx10Ubuntu 22.04, Navi3xUbuntu 20.04, Navi2x |
nhaehnle
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LGC is an LLVM external project, and thus cmake variables need to be set up to tell LLVM about it. Now that it is gaining dependencies that are themselves LLVM external projects (llvm-dialects, LgcCps), this gives a single place to update the cmake variable setting up.
This commit introduces: