Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amdllpc: Print error and exit, instead of asserting on error #2366

Merged
merged 1 commit into from
Mar 21, 2023
Merged

amdllpc: Print error and exit, instead of asserting on error #2366

merged 1 commit into from
Mar 21, 2023

Conversation

trenouf
Copy link
Member

@trenouf trenouf commented Mar 21, 2023

Previously a parse error (including not finding a shader file) caused it to abort at a VFX_NEVER_CALLED, and not show you the error message.

@trenouf
amdllpc: Print error and exit, instead of asserting on error
184d2ef 
Previously a parse error (including not finding a shader file) caused it
to abort at a VFX_NEVER_CALLED, and not show you the error message.
@trenouf trenouf requested a review from a team as a code owner March 21, 2023 08:26
amdrexu
amdrexu approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@amdrexu amdrexu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's very good. Thank you. I encountered this annoying assert for several times.

@amdvlk-admin
Copy link
Collaborator

Test summary for commit 184d2ef

CTS tests (Failed: 0/138230)
  • Built with version 1.3.0.0
    • Ubuntu 22.04, Navi3x
    • Passed: 36986/69126 (53.5%)
    • Failed: 0/69126 (0.0%)
    • Not Supported: 32140/69126 (46.5%)
    • Warnings: 0/69126 (0.0%)
    Ubuntu 20.04, Navi2x
    • Passed: 37206/69104 (53.8%)
    • Failed: 0/69104 (0.0%)
    • Not Supported: 31898/69104 (46.2%)
    • Warnings: 0/69104 (0.0%)
    Rhel 8.6, Gfx10
    • Timeout or crash

@trenouf trenouf merged commit 3eec035 into GPUOpen-Drivers:dev Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amdrexu amdrexu amdrexu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@trenouf @amdvlk-admin @amdrexu