fix: Check for existence of_ SC_AVPHYS_PAGES to fix MacOS compilation.

[CusiniM]

The merge of PR has broken compilation on my mac laptop. I have patched it like this.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.75%. Comparing base (94a0e86) to head (22737d9).
Report is 2 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3207   +/-   ##
========================================
  Coverage    55.75%   55.75%           
========================================
  Files         1041     1041           
  Lines        88534    88534           
========================================
  Hits         49358    49358           
  Misses       39176    39176           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rrsettgast]

Time to use the GitHub M1 runners?

[rrsettgast]

Is there another option on the Mac?

[CusiniM]

Is there another option on the Mac?

Is there another option on the Mac?

I found this but it's kind of old and I have not tried it.

[rrsettgast]

Is there another option on the Mac?

Is there another option on the Mac?

I found this but it's kind of old and I have not tried it.

@arng40 Can you give it a shot? Do you have a Mac?

[arng40]

Is there another option on the Mac?

Is there another option on the Mac?

I found this but it's kind of old and I have not tried it.

@arng40 Can you give it a shot? Do you have a Mac?

I don't have a MAC so it would be difficult to test alternatives.
A solution could be to integrate a compilation check on macos in CI

[MelReyCG]

Hello there, a few comments to contribute on this issue.

[MelReyCG]

Suggested change

	GEOS_WARNING( "Unknown device avaialable memory size getter for this system." );
	GEOS_WARNING( "Unknown device available memory size getter for this system." );

[MelReyCG]

Would something like this be a way to find the available memory on MaxOS? Unfortunately, I we don't have any MacOS to test that here.

Suggested change

	#else
	#elif /* is compiling for MacOS */
	{
	uint64_t mem;
	size_t len = sizeof( mem );
	sysctlbyname( "hw.memsize", &mem, &len, nullptr, 0 );
	m_availableMemory= mem / sysconf(_SC_PAGE_SIZE);
	}

Should we regroup the system-dependant component like this in a namespace ?

[CusiniM]

Is there another option on the Mac?

Is there another option on the Mac?

I found this but it's kind of old and I have not tried it.

@arng40 Can you give it a shot? Do you have a Mac?

I don't have a MAC so it would be difficult to test alternatives. A solution could be to integrate a compilation check on macos in CI

is it now available? I thought that we could not find any M1 runner but if they now have one we really should. It's true that we don't really need to support MacOS but a lot of us work on macbooks so it would be convenient to have a CI job to cover it.