Comments/Documentation for New Ghosting Architecture #3189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o feature/TotoGaz/newGhosting_ryan
… (Ryan's version)
23 tasks
|
Are you sure you do not want to merge into #3063 instead? |
ryar9534
changed the title
…Ghosting_ryan' into feature/TotoGaz/newGhosting_ryan
TotoGaz
reviewed
Jul 1, 2024
TotoGaz
reviewed
Jul 1, 2024
| @@ -219,6 +225,8 @@ FaceMgrImpl makeFlavorlessFaceMgrImpl( std::size_t const & numFaces, | |||
| toFlavorlessMapping( recv ) ); | |||
| } | |||
|
|
|||
| // Function to create a nodeManager from our local upward mapping data | |||
| // By flavorless, we are indicating that we are changing data-structures to GEOS ones, etc | |||
There was a problem hiding this comment.
flavorless is there to emphasize that we're no more using the strongly typed integers and fallback to localIndex and globalIndex.
TotoGaz
reviewed
Jul 1, 2024
TotoGaz
reviewed
Jul 1, 2024
| FaceInfo const & faceInfo = faces[i]; | ||
| ind[i] = convert.fromFaceGlbIdx( faceInfo.index ); | ||
|
|
||
| // Encode data with a single int like above, but now int tells us start_node, direction (flipped), and position of face in cell | ||
| // in this case v = 1 + (isFlipped*numFaces + start_index)*numFaces + index_in_cell (again add 1 so that zero indexing becomes 1 indexing) |
There was a problem hiding this comment.
We add one to be sure it's never 0 and is always "visible" and never "optimized out".
TotoGaz
reviewed
Jul 1, 2024
| auto const ownedMap = make_rcp< TriMap const >( Tpetra::global_size_t( n ), ownedGlbIdcs.data(), TriLocIdx( numOwned ), TriGlbIdx{ 0 }, comm ); | ||
|
|
||
| // The `upward` matrix offers a representation of the graph connections. | ||
| // The matrix is square. Each size being the number of geometrical entities. | ||
| // The matrix is just the assembed, global adjacency. | ||
| // Note that the matrix will end up being lower triangular, and banded because edge rows only have nonzeros in the node columns, faces only have nonzeros with edges, etc |
There was a problem hiding this comment.
In fact, it's lower triangular for "std" meshes. This may become different with fractures and cell to cell dependencies e.g..
TotoGaz
reviewed
Jul 1, 2024
| auto const ownedMap = make_rcp< TriMap const >( Tpetra::global_size_t( n ), ownedGlbIdcs.data(), TriLocIdx( numOwned ), TriGlbIdx{ 0 }, comm ); | ||
|
|
||
| // The `upward` matrix offers a representation of the graph connections. | ||
| // The matrix is square. Each size being the number of geometrical entities. | ||
| // The matrix is just the assembed, global adjacency. | ||
| // Note that the matrix will end up being lower triangular, and banded because edge rows only have nonzeros in the node columns, faces only have nonzeros with edges, etc | ||
| // Quick note on why we call it upward: |
There was a problem hiding this comment.
You can change the name. Like dependencies and dependents?
TotoGaz
reviewed
Jul 1, 2024
| // - The number of rows is the total number of graph nodes that are missing on ranks. | ||
| // For me this was confusing, as its a little different from what we've done before |
There was a problem hiding this comment.
We could have handled it with direct MPI communications instead of using linear algebra. Same for the node positions. Up to you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion to #3063 where I have added comments as I have walked through the new ghosting code