Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Log refactor - Output PVT #3149

Open
wants to merge 172 commits into
base: develop
Choose a base branch
from
Open

Conversation

arng40
Copy link
Contributor

@arng40 arng40 commented May 29, 2024

This PR follows the #2984 that aim to standardize logs.
Currently PVT tables are only accessible through .csv files. In this PR, logs will indicate which csv files are generated along with their associated path

CSV Generated to inputFiles/compositionalMultiphaseWell/test.xml/fluid1_phaseModel1_PhillipsBrineDensity_table.csv :

---------------------------------------------------------------------------------------
|                    fluid1_phaseModel1_PhillipsBrineDensity_table                    |
---------------------------------------------------------------------------------------
|  The fluid1_phaseModel1_PhillipsBrineDensity_table PVT table exceeding 500 rows.    |
|  To visualize the tables, go to the generated csv                                   |
---------------------------------------------------------------------------------------

In addition to csv files, PVT Tables with dimensions n <= 2 can be written in log by meetings 2 conditions :

  • have sufficient logLevel
  • Rows in the table < 500 lines

CSV Generated to inputFiles/compositionalMultiphaseWell/test.xml/fluid1_phaseModel1_PhillipsBrineViscosity_table.csv

---------------------------------------------------------
|    fluid1_phaseModel1_PhillipsBrineViscosity_table    |
---------------------------------------------------------
|    temperature [C]     |       viscosity [Pa*s]       |
---------------------------------------------------------
|          0.01          |          0.0017914           |
|           10           |           0.001306           |
|           20           |          0.0010016           |
|           25           |           0.00089            |
|           30           |          0.0007972           |
---------------------------------------------------------

An example of 2D table :

----------------------------------------------------------------------------------------------------------
|                             fluid1_phaseModel2_SpanWagnerCO2Density_table                              |
----------------------------------------------------------------------------------------------------------
|           density [kg/m3]  |  temperature [C] = 12  |  temperature [C] = 62  |  temperature [C] = 112  |
----------------------------------------------------------------------------------------------------------
|    pressure [Pa] = 100000  |     1.867036801109489  |    1.5846667997020552  |      1.377165506424985  |
|   pressure [Pa] = 1100000  |    21.873072823677948  |     18.05377355524998  |     15.472646535860257  |
|   pressure [Pa] = 2100000  |     45.02058216836334  |     35.79619626115461  |     30.190059516194083  |
|   pressure [Pa] = 3100000  |      73.0547505549322  |     55.06117914599007  |     45.580574187479066  |
						[...]
|  pressure [Pa] = 67100000  |     1107.292557196501  |     983.4638012355585  |      863.9649406367214  |
|  pressure [Pa] = 68100000  |    1109.1855359680847  |     986.2233300634709  |       867.698289923355  |
|  pressure [Pa] = 69100000  |    1111.0569954467694  |     988.9398867966821  |      871.3611145780119  |
|  pressure [Pa] = 70100000  |    1112.9074848288449  |      991.614907000032  |      874.9561390383249  |
|  pressure [Pa] = 71100000  |    1114.7375318533834  |     994.2497540203499  |      878.4859333715468  |
|  pressure [Pa] = 72100000  |    1116.5476438596384  |     996.8457238250027  |      881.9529245875995  |
|  pressure [Pa] = 73100000  |    1118.3383088824808  |     999.4040493886989  |      885.3594069497734  |
|  pressure [Pa] = 74100000  |    1120.1099966304896  |    1001.9259047775354  |      888.7075513940321  |
----------------------------------------------------------------------------------------------------------

…feature/dudes/table-layout"

This reverts commit 8f74cfa.
@rrsettgast
Copy link
Member

@arng40 This PR is not approved. I am moving it off of the queue.

Copy link
Contributor

@paveltomin paveltomin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address a couple of my comments

Copy link
Contributor

@MelReyCG MelReyCG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few requests

@arng40 arng40 requested a review from MelReyCG July 8, 2024 15:13
@arng40 arng40 changed the title Log refactor - Output PVT feat: Log refactor - Output PVT Jul 12, 2024
@arng40
Copy link
Contributor Author

arng40 commented Jul 12, 2024

Hello @herve-gross , to get my PR into the merge queue, which code owners do I need to have approved?
Because of merging with the develop, a lot of the code owners seem to be required.

@herve-gross
Copy link
Contributor

Hello @herve-gross , to get my PR into the merge queue, which code owners do I need to have approved? Because of merging with the develop, a lot of the code owners seem to be required.

@rrsettgast is the right person for this.

@CusiniM
Copy link
Collaborator

CusiniM commented Jul 12, 2024

Hello @herve-gross , to get my PR into the merge queue, which code owners do I need to have approved? Because of merging with the develop, a lot of the code owners seem to be required.

it's based on the folders you touched. What's a bit annoying is that it's not very easy to know which are the strictly necessary ones. you only need one codeowner for each folder but github does not really tell you what is the minimum subset. You can kind of figure it out by hoovering on the files in the Files changed view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI DO NOT MERGE !
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PVT data tables in the log (density, saturation...),
7 participants