-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Log refactor - Output PVT #3149
base: develop
Are you sure you want to change the base?
Conversation
…dudes/table-layout
…feature/dudes/table-layout" This reverts commit 8f74cfa.
…nto feature/dudes/table-layout
@arng40 This PR is not approved. I am moving it off of the queue. |
src/coreComponents/constitutive/fluid/multifluid/CO2Brine/CO2BrineFluid.cpp
Outdated
Show resolved
Hide resolved
src/coreComponents/constitutive/fluid/multifluid/CO2Brine/CO2BrineFluid.cpp
Outdated
Show resolved
Hide resolved
src/coreComponents/constitutive/fluid/multifluid/reactive/ReactiveBrineFluid.cpp
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please address a couple of my comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few requests
src/coreComponents/constitutive/fluid/multifluid/CO2Brine/CO2BrineFluid.hpp
Outdated
Show resolved
Hide resolved
src/coreComponents/constitutive/fluid/multifluid/CO2Brine/CO2BrineFluid.hpp
Outdated
Show resolved
Hide resolved
src/coreComponents/constitutive/fluid/multifluid/reactive/ReactiveBrineFluid.hpp
Show resolved
Hide resolved
src/coreComponents/constitutive/fluid/multifluid/CO2Brine/CO2BrineFluid.cpp
Outdated
Show resolved
Hide resolved
src/coreComponents/constitutive/fluid/multifluid/CO2Brine/CO2BrineFluid.cpp
Outdated
Show resolved
Hide resolved
Hello @herve-gross , to get my PR into the merge queue, which code owners do I need to have approved? |
@rrsettgast is the right person for this. |
it's based on the folders you touched. What's a bit annoying is that it's not very easy to know which are the strictly necessary ones. you only need one codeowner for each folder but github does not really tell you what is the minimum subset. You can kind of figure it out by hoovering on the files in the |
This PR follows the #2984 that aim to standardize logs.
Currently PVT tables are only accessible through
.csv
files. In this PR, logs will indicate which csv files are generated along with their associated pathCSV Generated to inputFiles/compositionalMultiphaseWell/test.xml/fluid1_phaseModel1_PhillipsBrineDensity_table.csv :
In addition to csv files, PVT Tables with dimensions n <= 2 can be written in log by meetings 2 conditions :
logLevel
CSV Generated to inputFiles/compositionalMultiphaseWell/test.xml/fluid1_phaseModel1_PhillipsBrineViscosity_table.csv
An example of 2D table :