Fix #3146 - Error in stat reduction for Function triggered PeriodicEvent

[jafranc]

Fix #3146 - Error in stat reduction for Function triggered PeriodicEvent

Using such a XML block as

    <PeriodicEvent
      name="ConditionalDump"
            logLevel="2"
      maxEventDt="0.1"
            function="sg"
            threshold="0.1"
            object="/Problem/.../mesh/.../c2"
            stat="0"
            target="/Outputs/vtkOutput"/>

Attempting to use function attribute of Periodic event and its related attribute stat to trigger periodic event if min (0 is for min, 1 is for average, 2 is for max) of the function is above threshold was not working properly:

• in parallel
• if stat=2, i.e. for maximum

indeed,

• reduction for parallel runs other than max were not implemented.
• a typo in FunctionBase.cpp was comparing min to max.

Moreover, for partitions not intersecting (N=0 in FunctionBase.cpp)
with object the workflow was returning 1e10 for min and -1e10 for max in parallel reductions.

[paveltomin]

@jafranc can you explain a little bit what was the issue and how you got it fixed?

[jafranc]

@jafranc can you explain a little bit what was the issue and how you got it fixed?

I updated the description above. I am reporting Oleg experience and fix there.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 55.88%. Comparing base (399ec9d) to head (1d488d8).

Files	Patch %	Lines
src/coreComponents/events/PeriodicEvent.cpp	0.00%	13 Missing ⚠️
src/coreComponents/functions/FunctionBase.cpp	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3147      +/-   ##
===========================================
- Coverage    55.89%   55.88%   -0.01%     
===========================================
  Files         1037     1037              
  Lines        88148    88159      +11     
===========================================
- Hits         49271    49269       -2     
- Misses       38877    38890      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.