Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temperature dependent single phase thermal conductivity #3135

Open
wants to merge 23 commits into
base: develop
Choose a base branch
from

Conversation

sytuannguyen
Copy link
Contributor

@sytuannguyen sytuannguyen commented May 22, 2024

This PR is part of the project for non-linear thermal constitutive behavior from TotalEnergies. It tackles the problem of linear temperature dependent single phase effective thermal conductivity of porous medium.

thermalConductivity = defaultThermalConductivity + dThermalConductivity_dT * (T - T_reference)

where defaultThermalConductivity, dThermalConductivity_dT and T_reference are given in the xml input. The existing linear model in GEOS corresponds to the particular case of a constant thermal conductivity, i.e. dThermalConductivity_dT = 0.

  • Implement the non linear thermal constitutive model
  • Update the thermal single phase flow with respect to non linear thermal behavior
  • Update xml files to add new inputs: dThermalConductivity_dT and T_reference
  • Integrated test
  • Unit test
  • Validation example: doc and Python script for validation

Copy link
Contributor

@herve-gross herve-gross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Sy Tuan. Lots of change in this PR, but everything looks in order.

@sytuannguyen sytuannguyen marked this pull request as ready for review June 26, 2024 01:38
@sytuannguyen sytuannguyen added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: requires rebaseline Requires rebaseline branch in integratedTests labels Jun 26, 2024
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 81.70732% with 15 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@44efb98). Learn more about missing BASE report.

Files Patch % Lines
...Solvers/fluidFlow/ThermalSinglePhaseFVMKernels.hpp 46.15% 7 Missing ⚠️
...Components/constitutive/solid/CoupledSolidBase.hpp 42.85% 4 Missing ⚠️
...malConductivity/SinglePhaseThermalConductivity.hpp 88.46% 3 Missing ⚠️
...onductivity/SinglePhaseThermalConductivityBase.cpp 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #3135   +/-   ##
==========================================
  Coverage           ?   49.33%           
==========================================
  Files              ?     1037           
  Lines              ?    88227           
  Branches           ?        0           
==========================================
  Hits               ?    43527           
  Misses             ?    44700           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes XML input ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: requires rebaseline Requires rebaseline branch in integratedTests type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants