Logger / LogLevel rework #3134
Draft
Logger / LogLevel rework #3134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remplacement des min/max par une option overrideLogLevel - globalLogLevel ne se configure que dans le xml et est renommé problemLogLevel - nouvelle collection de méthode de logging - fix d'une typo (SolidMechanicsLagrangianFEM::TimeIntegrationOption) - ajout d'une option logs-folder de command-line
(+ removed generated png)
Logger.xpp will be removed.
MelReyCG
commented
Jul 11, 2024
Comment on lines
+35
to
+47
| template< typename CONTEXT_T > | ||
| class LoggingObject | ||
| { | ||
|
|
||
| void setLogLevel( LogLevel value ); | ||
|
|
||
|
|
||
| virtual void logRank0( LogMsg::CallParams loc, string_view msg, LogRouter router = LogRouter::m_main ) const = 0; | ||
|
|
||
| // TODO not exactly sure how to implement that (avoid formating if cond is false, keeping condition as metadata). | ||
| // virtual void logRank0If( bool cond, LogMsg::CallParams loc, string_view msg, LogRouter router = LogRouter::m_main ) const = 0; | ||
|
|
||
| virtual void log( LogMsg::CallParams loc, string_view msg, LogRouter router = LogRouter::m_main ) const = 0; |
There was a problem hiding this comment.
@rrsettgast As the meeting of today concluded, I will explore a solution where LoggingObject would be a "light version" when called from a kernel. If that does not work, I will go for macros.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR