Implementing hybrid upwinding for total velocity schemes #2394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/coreComponents/finiteVolume/FluxApproximationBase.cpp # src/coreComponents/finiteVolume/FluxApproximationBase.hpp # src/coreComponents/physicsSolvers/fluidFlow/IsothermalCompositionalMultiphaseFVMKernels.hpp # src/coreComponents/unitTests/fluidFlowTests/CMakeLists.txt
…ature/jafranc/hybrid-upwinding
…/GEOSX/GEOSX into feature/jafranc/hybrid-upwinding
|
@jafranc will you have time to merge it? |
It is plan for early march as needed for other projects |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2394 +/- ##
===========================================
- Coverage 53.43% 53.18% -0.25%
===========================================
Files 981 981
Lines 83062 83437 +375
===========================================
- Hits 44382 44380 -2
- Misses 38680 39057 +377 ☔ View full report in Codecov by Sentry. |
paveltomin
added
the
ci: run integrated tests
added 3 commits
March 7, 2024 14:39
…/GEOS-DEV/GEOS into feature/jafranc/hybrid-upwinding
paveltomin
added
ci: run CUDA builds
CusiniM
approved these changes
Mar 16, 2024
|
this does not seem to require baselines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up #2410, this PR aims at implementing simple version of Implicit Hybrid Upwinding (IHU). It implements
IHUPhaseFluxequivalent toC1PPUPhaseFluxorPPUPhaseFluxlocated inIsothermalCompositionalMultiphaseFVMKernelUtilities.hpp. It serves as a dispatch value inFaceBasedAssemblyKernelFactory::createAndLaunch().some refs on IHU:
"Implicit Hybrid Upwinding for two-phase flow in heterogeneous porous media with buoyancy and capillarity"(Hamon et al,2018)
"Consistent upwinding for sequential fully implicit multiscale compositional simulation" (Moncorge et al,2020)
"Implicit Hybrid Upwinding for two-phase flow in heterogeneous porous media with buoyancy and capillarity"(Hamon et al,2018)
It also introduces
UpwindHelpersnamespace to scope helpers functions computing upwinded fractional flows and potential fluxes that are useful in IHU (and other schemes). Eventually, it introduces an Abstract classUpwindSchemeintroducing high level mechanisms to compute upwind direction and fluxes and its Derived classHybridUpwindto implement specifics to IHU.It could be complemented and extended by adding new upwinding schemes such as Phase Upwind (PU) or weighted Hybrid Upwind (wIHU)
"Smooth implicit hybrid upwinding for compositional multiphase flow in porous media"(Bosma et al, 2022)
"Upstream Differencing for Multiphase Flow in Reservoir Simulation"