Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added validation example for Problem 3.x of Class (2009) - Part 1 #1853

Merged
merged 33 commits into from
Nov 20, 2022

Conversation

jafranc
Copy link
Contributor

@jafranc jafranc commented Mar 26, 2022

This PR is following #1723 in adding a validation case on Johansen mesh as proposed in the third problem (Problem 3.x) of the benchmark paper: "A benchmark study on problems related to CO 2 storage in geologic formations", Class et al, 2009.

The mesh data has been stored in GEOSX_DATA 's Dataset and is associated with PR 10.

The boundary conditions are imposed on domain faces and statistics are generated using CompositionalMultiphaseStatistics and extracted from logs thanks to postt_clas09_3.py

Major update:

  • Going from boundary cell BC to face BC
  • Changing the mesh accordingly
  • Switching from multiple TimeHistoryOutput to CompositionalMultiphaseStatistics
  • Changing post-processing script accordingly

A follow up on this tutorial would include thermal effects and similar outputs.

Rebaseline done in https://github.com/GEOSX/integratedTests/pull/278

@rrsettgast rrsettgast removed the new label Aug 30, 2022
@jafranc
Copy link
Contributor Author

jafranc commented Oct 22, 2022

Changed from layer of cell boundary to face boundary.
Changed from TimeHistoryOutput to extraction of reservoirStatictics from log.

Still few things to fix in plotting script.

During DocDay we discussed about the thermal problem, and we think it should be in a partII in its own PR. Let me know if you agree 😃

# Conflicts:
#	inputFiles/compositionalMultiphaseFlow/benchmarks/thermalLeakyWell/co2flash.txt
#	inputFiles/compositionalMultiphaseFlow/benchmarks/thermalLeakyWell/pvtgas.txt
#	inputFiles/compositionalMultiphaseFlow/benchmarks/thermalLeakyWell/pvtliquid.txt
#	inputFiles/compositionalMultiphaseFlow/benchmarks/thermalLeakyWell/thermalLeakyWell_benchmark.xml
@jafranc jafranc changed the title Added validation example for Problem 3.x of Class (2009) Added validation example for Problem 3.x of Class (2009) - Part 1 Nov 4, 2022
@jafranc jafranc marked this pull request as ready for review November 4, 2022 18:02
Copy link
Contributor

@francoishamon francoishamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, close to ready to be merged. Maybe you can move this PR to non-draft to activate the generation of the documentation, which will make it easier to check.

@francoishamon francoishamon added flag: requires rebaseline Requires rebaseline branch in integratedTests flag: ready for review labels Nov 16, 2022
@francoishamon francoishamon merged commit 94a8c78 into develop Nov 20, 2022
@francoishamon francoishamon deleted the docs/jfranc/Class09Pb3xValidationCase branch November 20, 2022 02:59
@jafranc
Copy link
Contributor Author

jafranc commented Nov 20, 2022

Many thanks for cleaning/merging it @francoishamon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants