-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added validation example for Problem 3.x of Class (2009) - Part 1 #1853
Added validation example for Problem 3.x of Class (2009) - Part 1 #1853
Conversation
…9Pb3xValidationCase
…to docs/jfranc/Class09Pb3xValidationCase
…9Pb3xValidationCase
Changed from layer of cell boundary to face boundary. Still few things to fix in plotting script. During DocDay we discussed about the thermal problem, and we think it should be in a partII in its own PR. Let me know if you agree 😃 |
# Conflicts: # inputFiles/compositionalMultiphaseFlow/benchmarks/thermalLeakyWell/co2flash.txt # inputFiles/compositionalMultiphaseFlow/benchmarks/thermalLeakyWell/pvtgas.txt # inputFiles/compositionalMultiphaseFlow/benchmarks/thermalLeakyWell/pvtliquid.txt # inputFiles/compositionalMultiphaseFlow/benchmarks/thermalLeakyWell/thermalLeakyWell_benchmark.xml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, close to ready to be merged. Maybe you can move this PR to non-draft to activate the generation of the documentation, which will make it easier to check.
...s/compositionalMultiphaseFlow/benchmarks/Class09Pb3/class09_pb3_drainageOnly_direct_base.xml
Outdated
Show resolved
Hide resolved
...s/compositionalMultiphaseFlow/benchmarks/Class09Pb3/class09_pb3_drainageOnly_direct_base.xml
Outdated
Show resolved
Hide resolved
...s/compositionalMultiphaseFlow/benchmarks/Class09Pb3/class09_pb3_drainageOnly_direct_base.xml
Outdated
Show resolved
Hide resolved
...ompositionalMultiphaseFlow/benchmarks/Class09Pb3/class09_pb3_drainageOnly_iterative_base.xml
Outdated
Show resolved
Hide resolved
...ompositionalMultiphaseFlow/benchmarks/Class09Pb3/class09_pb3_drainageOnly_iterative_base.xml
Outdated
Show resolved
Hide resolved
.../sphinx/advancedExamples/validationStudies/carbonStorage/isothermalHystInjection/Example.rst
Outdated
Show resolved
Hide resolved
.../sphinx/advancedExamples/validationStudies/carbonStorage/isothermalHystInjection/Example.rst
Outdated
Show resolved
Hide resolved
.../sphinx/advancedExamples/validationStudies/carbonStorage/isothermalHystInjection/Example.rst
Outdated
Show resolved
Hide resolved
.../sphinx/advancedExamples/validationStudies/carbonStorage/isothermalHystInjection/Example.rst
Outdated
Show resolved
Hide resolved
.../sphinx/advancedExamples/validationStudies/carbonStorage/isothermalHystInjection/Example.rst
Outdated
Show resolved
Hide resolved
Many thanks for cleaning/merging it @francoishamon :) |
This PR is following #1723 in adding a validation case on Johansen mesh as proposed in the third problem (Problem 3.x) of the benchmark paper: "A benchmark study on problems related to CO 2 storage in geologic formations", Class et al, 2009.
The mesh data has been stored in GEOSX_DATA 's Dataset and is associated with PR 10.
The boundary conditions are imposed on domain faces and statistics are generated using
CompositionalMultiphaseStatistics
and extracted from logs thanks topostt_clas09_3.py
Major update:
TimeHistoryOutput
toCompositionalMultiphaseStatistics
A follow up on this tutorial would include thermal effects and similar outputs.
Rebaseline done in https://github.com/GEOSX/integratedTests/pull/278