Fix location string parsing regex in JS to allow for space before point field brackets. #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt field brackets.
|
Hi @solarissmoke and thanks for the PR, I have tried your fix and it works great. Many thanks! Will try to do a release this afternoon. |
|
Its out now (https://github.com/Frojd/wagtail-geo-widget/releases/tag/v5.0.2), again, many thanks! |
|
That was quick - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
The
GeoPaneldoesn't currently work with GeoDjangoPointFields because of a small difference in how the string representation of the value is rendered. Django renders aPointFieldlike so:There is a space after
POINTand before the opening bracket.The JS currently expects no space (
POINT(36.803684 -1.271821)), and so parsing of the field fails. This patch modifies the regex to allow an optional space.