Fixing edit_handlers.py for wagtail 4 (new permission option on fieldpanels not working) #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A wrong override of clone method shadows additional keyword arguments like the new "permission" option in Wagtail 4
|
Now #111 got merged. edit_handlers.py was renamed. But this issue remains unsolved. |
|
@unicode-it Thanks for the PR! At first glance this looks good, I just need to replicate the original issue and test it. |
|
@unicode-it Just wanted to let you now that your changes has been added in this commit 58d4646 and is included in https://github.com/Frojd/wagtail-geo-widget/releases/tag/v7.0.0. Again thank your for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A wrong override of clone method shadows additional keyword arguments like the new "permission" option in Wagtail 4