Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create fr translation #105

Closed
wants to merge 1 commit into from
Closed

create fr translation #105

wants to merge 1 commit into from

Conversation

ThbtSprt
Copy link
Contributor

@ThbtSprt ThbtSprt commented Apr 5, 2022

No description provided.

@marteinn
Copy link
Member

marteinn commented Apr 6, 2022

Hi @ThbtSprt and thanks for the PR, I think the translation looks good. One thing though is that I have noticed that you have branched from main in your PR, would it be possible to branch from develop instead? (As we are using gitflow in this repo). Thanks!

@ThbtSprt ThbtSprt closed this Apr 6, 2022
@ThbtSprt ThbtSprt reopened this Apr 6, 2022
@ThbtSprt ThbtSprt closed this Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ThbtSprt @marteinn