Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add volume to mysql container #4

Merged
merged 1 commit into from
Apr 21, 2017
Merged

Add volume to mysql container #4

merged 1 commit into from
Apr 21, 2017

Conversation

mmahrous
Copy link
Contributor

Add volume to mysql container to save the data base in case anything happen

Add volume to mysql container to save the data base in case anything happen
@marteinn
Copy link
Member

Hi @mmahrous and thanks for the PR! On which systems have you tested the volume write? I'm asking because I have had permission issues when doing the same thing with PostgreSQL when running docker toolbox on MacOS.

@mmahrous
Copy link
Contributor Author

Hello @marteinn I used Debian 8.7 x64, what kind of permission issue that you faced I use volume with all of my containers on MacOS.

@marteinn
Copy link
Member

@mmahrous I did some further research and it seems like docker for mac solved that (unrelated) issue. Great to hear that it is tested on MacOS, I will talk with the team tomorrow about this PR before accepting, it would be nice to have a persistent db :)

@mmahrous
Copy link
Contributor Author

great to hear that, yes cause I had a problem that I lost my database in production phase because of this and I managed to get it back from docker tmp volumes, anyway waiting for the merge :)

@mikaelengstrom
Copy link
Member

@mmahrous, thanks!

@marteinn, i am fine with this. Lets merge?

@marteinn
Copy link
Member

@mikaelengstrom Lets do it 👍

@marteinn marteinn merged commit 4819984 into Frojd:master Apr 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants