Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component-wise MCMC for subset simulation #166

Merged
merged 6 commits into from
May 15, 2024
Merged

Conversation

AnderGray
Copy link
Collaborator

This PR changes the MCMC sampler in SubSetSimulation from usual Metropolis-Hastings, to component-wise MH. Dimensions are accepted independently, giving a better acceptance rate in higher dimensions.

closes #165

Copy link
Owner

@FriesischScott FriesischScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what the issue with the actions is. Apart from some very minor suggestions this looks good to me.

src/simulations/subset.jl Outdated Show resolved Hide resolved
src/simulations/subset.jl Outdated Show resolved Hide resolved
src/simulations/subset.jl Outdated Show resolved Hide resolved
@AnderGray
Copy link
Collaborator Author

Thanks for taking a look, everything should be addressed

@FriesischScott FriesischScott added the enhancement Improvement of existing code label May 14, 2024
Copy link
Owner

@FriesischScott FriesischScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

Repository owner deleted a comment from AnderGray May 15, 2024
Repository owner deleted a comment from AnderGray May 15, 2024
@FriesischScott FriesischScott merged commit ef43046 into master May 15, 2024
9 checks passed
@FriesischScott FriesischScott deleted the modified_mcmc branch May 15, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We're not using Modified (component-wise) MCMC in subset simulation
2 participants