Fix (improve) unstable tests #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It now tests that all values are positive and the pdf integrates to 1.
|
Something seems very wrong here. It fails the test for samples drawn from a normal. They aren't even transformed. How is the pvalue this low? |
|
Are hypothesis test just useless? Even if I sample a standard normal, the test will return anything between 0 and 1. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #149 +/- ##
=======================================
Coverage 98.27% 98.27%
=======================================
Files 27 27
Lines 1045 1045
=======================================
Hits 1027 1027
Misses 18 18 ☔ View full report in Codecov by Sentry. |
|
While the hypothesis tests didn't work out, this at least improves the stability of the tests as far as I can tell. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the unstable tests for empirical distributions and mappings to standard normal space.
Closes #148.