Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Discussions to Help section of the About tab #3901

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc commented Aug 21, 2023

Add Discussions to About tab

Pull Request Type

  • Chore

Description

Noticed that this the Discussions page wasn't added to the About tab so i added it to the Help section of the About tab.

Testing

Go to the about tab and check if Discussions is available in the Help section
Also try to click on it

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Aug 21, 2023
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) August 21, 2023 08:32
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc changed the title Add Discussions to About tab Add Discussions to Help section of the About tab Aug 21, 2023
@PikachuEXE
Copy link
Collaborator

Translation entry missing?
image

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member Author

Oh what in the world.....Not sure why it shows the "About." because i formatted it the same as the rest?

Capture

@PikachuEXE
Copy link
Collaborator

PikachuEXE commented Aug 21, 2023

Coz missing translation entry? static/locales/en-US.yaml:
image

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member Author

Oh lol i thought i had added that smh

@PikachuEXE
Copy link
Collaborator

Cannot post GIF I am sad
image

@FreeTubeBot FreeTubeBot merged commit 4d85ef8 into development Aug 22, 2023
6 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Aug 22, 2023
@ChunkyProgrammer ChunkyProgrammer deleted the add-discussions branch August 22, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants