Fixes #515 #519
Closed
Fixes #515 #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there anything that needs to be done on this before it can be merged into master? I am having the same issues as @AlexanderLyon and others mentioned on rotating and then resizing a rectangle in #515. |
|
I'm not opposed to this approach (although it may seem like since I haven't responded in almost a year). Sorry for not responding to this PR earlier, just been caught up in other things. But I do think this comment is right: #515 (comment). If someone rotates the image |
|
That makes sense. If @AlexanderLyon isn't interested or doesn't have time to make that change I can create a PR next week. |
|
Thanks @jedsmith13! |
thedustinsmith
pushed a commit
that referenced
this pull request
Apr 17, 2019
* Fixes #515 * Added if for 180 as suggested by @bwakabats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the image is rotated it was keeping its old height and width, sometimes resulting in a distorted rectangle. This is changed to reflect the new dimensions.