Remove Base.parameter_upper_bound given removal from Base #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! bors r+ |
|
Build succeeded: |
|
@DhairyaLGandhi just for your radar, this is also blocking on master FluxML/IRTools.jl#71 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base.parameter_upper_boundhas been removed on julia master, so was breaking Flux on julia master.It doesn't seem to be mentioned anywhere other than this in Zygote
I couldn't find where it left base, but perhaps it wasn't intended to be used anyway given JuliaLang/julia#36769 (comment)
I can't vouch for just deleting this being a good idea, other than I couldn't find any other mention in the Zygote source, but either way it needs fixing