Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RNN docs #1428

Merged
merged 13 commits into from
Dec 24, 2020
Merged

RNN docs #1428

merged 13 commits into from
Dec 24, 2020

Conversation

jeremiedb
Copy link
Contributor

This PR is to augment the documentation around the recurrence structure to address frequent questions raised about how to handle the recurrent tools for various use cases.

This is presented as an additional component to the current Recurrent doc. I'm unclear if it would be preferable to attempt to blend the current docs into a single page on recurrence?

Copy link
Member

@ToucheSir ToucheSir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! I vote for merging with the current RNN page, as having a "continued" page would be somewhat awkward for navigation.

@jeremiedb
Copy link
Contributor Author

jeremiedb commented Dec 16, 2020

@ToucheSir Makes much sense! So I'll rework to merge some the more detailed Recurrent cell logic from the original docs into the new expanded explanations.

@jeremiedb
Copy link
Contributor Author

@CarloLucibello / @DhairyaLGandhi Update to the recurrent docs would be now ready for review.

@jeremiedb
Copy link
Contributor Author

@ToucheSir Just bumping to avoid it falls in a crack. Is there anything else needed for merge?

@CarloLucibello
Copy link
Member

best documentation page we'll have in Flux, thanks!

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 24, 2020

Build succeeded:

@bors bors bot merged commit 843b4d4 into FluxML:master Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants