Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow CuArrays v2.x #1098

Merged
merged 6 commits into from
Mar 26, 2020
Merged

Allow CuArrays v2.x #1098

merged 6 commits into from
Mar 26, 2020

Conversation

ararslan
Copy link
Contributor

No description provided.

@DhairyaLGandhi
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Mar 25, 2020
@bors
Try #1098:
0e041d0
@bors
Copy link
Contributor

bors bot commented Mar 25, 2020

try

Build succeeded

@DhairyaLGandhi
Copy link
Member

Could you also bump the version in the Manifest please? Thanks @ararslan!

@ararslan
Copy link
Contributor Author

Done!

@ararslan
Copy link
Contributor Author

Hm, I'm not sure what's going on with the Travis failure but it does look related. I guess it's expecting a CUDA installation, which is why it worked on the GPU-enabled Gitlab CI.

@ararslan
Copy link
Contributor Author

The amazing @maleadt found that the source of the issue is with CUDAdrv. He'll be addressing that (with tests to catch it) upstream soon.

@ararslan
Copy link
Contributor Author

Ah, looks like this will need JuliaGPU/CuArrays.jl#650 too.

@maleadt
Copy link
Collaborator

maleadt commented Mar 26, 2020

JuliaRegistries/General#11588. I think this will also need #1050 though.

@CarloLucibello
Copy link
Member

@maleadt we should drop cuarrays 1.6 support if #1050 gets in, right?

@DhairyaLGandhi
Copy link
Member

Merged #1050 here, could use a manifest bump

@maleadt
Copy link
Collaborator

maleadt commented Mar 26, 2020

@maleadt we should drop cuarrays 1.6 support if #1050 gets in, right?

Correct.

@DhairyaLGandhi
Copy link
Member

DhairyaLGandhi commented Mar 26, 2020 •
edited

Is it limited to 1.6 or would we also drop 1.7 support here?

1.x basically

@maleadt
Copy link
Collaborator

maleadt commented Mar 26, 2020

Is it limited to 1.6 or would we also drop 1.7 support here?

Sorry, you also need to drop 1.7. The change is only in 2.0.

@maleadt
Copy link
Collaborator

maleadt commented Mar 26, 2020

bors try

bors bot added a commit that referenced this pull request Mar 26, 2020
@bors
Try #1098:
06141e2
@bors
Copy link
Contributor

bors bot commented Mar 26, 2020

try

Build succeeded

@DhairyaLGandhi
Copy link
Member

bors r+

@bors bors bot merged commit 6b37ce3 into FluxML:master Mar 26, 2020
@bors
Copy link
Contributor

bors bot commented Mar 26, 2020

Build succeeded

@DhairyaLGandhi
Copy link
Member

Thanks guys!

@ararslan ararslan deleted the aa/cuarrays branch March 26, 2020 16:26
@ararslan
Copy link
Contributor Author

Any chance we could get a patch release with this change?

@jgreener64
Copy link

Patch release would be really useful.

@CarloLucibello CarloLucibello mentioned this pull request Apr 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ararslan @DhairyaLGandhi @maleadt @CarloLucibello @jgreener64