Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipewire's Jack implementation not found by CMake #1268

Closed
pedrolcl opened this issue Aug 16, 2023 · 1 comment · Fixed by #1269
Closed

Pipewire's Jack implementation not found by CMake #1268

pedrolcl opened this issue Aug 16, 2023 · 1 comment · Fixed by #1269
Labels
bug

Comments

@pedrolcl
Copy link
Contributor

FluidSynth version

2.3.3

Describe the bug

Pipewire's Jack implementation is not detected at CMake configuration. CMake outputs:
-- Could NOT find Jack (missing: Jack_LIBRARY)

Expected behavior

Pipewire's Jack implementation should be detected and accepted, like jack1 and jack2.

Steps to reproduce

Install the Pipewire Jack implementation (headers and libs), but not any other jack implementation. For instance, in Fedora it is:
pipewire-jack-audio-connection-kit-devel.x86_64 : Development files for pipewire-jack-audio-connection-kit
$ sudo dnf install pipewire-jack-audio-connection-kit-devel

Additional context

There are three Jack implementations currently found on most Linux distros nowadays. Fluidsynth should compile and work with any of them.
@pedrolcl pedrolcl added the bug label Aug 16, 2023
@pedrolcl
Copy link
Contributor Author

pedrolcl commented Aug 16, 2023 •
edited
Loading

This is the content of the Fedora RPM package:

$ rpm -ql pipewire-jack-audio-connection-kit-devel
/usr/include/jack
/usr/include/jack/control.h
/usr/include/jack/intclient.h
/usr/include/jack/jack.h
/usr/include/jack/jslist.h
/usr/include/jack/metadata.h
/usr/include/jack/midiport.h
/usr/include/jack/net.h
/usr/include/jack/ringbuffer.h
/usr/include/jack/session.h
/usr/include/jack/statistics.h
/usr/include/jack/systemdeps.h
/usr/include/jack/thread.h
/usr/include/jack/transport.h
/usr/include/jack/types.h
/usr/include/jack/uuid.h
/usr/include/jack/weakjack.h
/usr/include/jack/weakmacros.h
/usr/lib64/pipewire-0.3/jack/libjack.so
/usr/lib64/pipewire-0.3/jack/libjacknet.so
/usr/lib64/pipewire-0.3/jack/libjackserver.so
/usr/lib64/pkgconfig/jack.pc

Contents of jack.pc:

$ cat /usr/lib64/pkgconfig/jack.pc
prefix=/usr
includedir=${prefix}/include
libdir=${prefix}/lib64

server_libs=-L${libdir} -ljackserver
jack_implementation=pipewire

Name: jack
Description: PipeWire JACK API
Version: 1.9.17
Libs: -L${prefix}/lib64/pipewire-0.3/jack -ljack
Cflags: -I${includedir} -D_REENTRANT

See also this Pipewire PR

pedrolcl added a commit to pedrolcl/fluidsynth that referenced this issue Aug 16, 2023
@pedrolcl
fix for issue FluidSynth#1268: Pipewire's Jack implementation not found
ab449e8
@pedrolcl pedrolcl mentioned this issue Aug 16, 2023
Merged
derselbst pushed a commit that referenced this issue Aug 19, 2023
@pedrolcl
fix for issue #1268: Pipewire's Jack implementation not found (#1269)
6721e92
DominusExult added a commit to DominusExult/fluidsynth-sans-glib that referenced this issue Mar 6, 2024
@DominusExult
Merge commit '683270db64302e59d26b9610514af1cfe0a80493' into sans_glib
2c7e16d 
* commit '683270db64302e59d26b9610514af1cfe0a80493':
  Bump to 2.3.5
  Fix libinstpatch and sndfile not being discovered on Windows (FluidSynth#1299)
  Update FreeBSD CI: Drop 12.4 and add 14.0
  Fix some rounding issues due to double promotion (FluidSynth#1286)
  Bump to 2.3.4
  Fix player termination after stopping and restarting (FluidSynth#1273)
  fix for issue FluidSynth#1268: Pipewire's Jack implementation not found (FluidSynth#1269)
  Fix issue with CMake Xcode generator (FluidSynth#1266)
  Refurbish CI (FluidSynth#1267)
  Fallback to IPv4 when creating socket if IPv6 is not available (FluidSynth#1208) (FluidSynth#1265)
  Turn off pending notes and issue a warning (FluidSynth#1264)
  Fix incorrect way of turning CMAKE_INSTALL_LIBDIR absolute (FluidSynth#1261)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix for issue #1268: Pipewire's Jack implementation not found pedrolcl/fluidsynth
1 participant
@pedrolcl