You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change seems large because it is deleting a significant amount of vendored/generated code. Functionally, the bulk of the change is updating a handful of dependencies, which includes a dependency was previously vendored/generated, but can use a pre-built artifact going forward.
Everything under firebase_apis/test_api is vendored/generated based on the json API discovery document for the testing API or similar. Based on this comment, it seems like this was done to leverage code that wasn't available as part of the publicly available testing api jar at the time. The unit and integration tests pass using the currently available testing api jar, and so it's no longer necessary to maintain the firebase_apis/test_api sub-project, and flank can depend on the newest/current publicly available jar.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2372
This change seems large because it is deleting a significant amount of vendored/generated code. Functionally, the bulk of the change is updating a handful of dependencies, which includes a dependency was previously vendored/generated, but can use a pre-built artifact going forward.
Everything under firebase_apis/test_api is vendored/generated based on the json API discovery document for the testing API or similar. Based on this comment, it seems like this was done to leverage code that wasn't available as part of the publicly available testing api jar at the time. The unit and integration tests pass using the currently available testing api jar, and so it's no longer necessary to maintain the firebase_apis/test_api sub-project, and flank can depend on the newest/current publicly available jar.
Test Plan
Unit and integration tests are still passing
Checklist