Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: WIP - Create change requests for segments #4265

Open
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

zachaysan
Copy link
Contributor

Changes

I'm working through creating change requests for segments on both this repository and on the workflows one. I'm going to try to keep WIP PRs to avoid losing my work if there is data loss.

How did you test this code?

Tests still required, although most of it will eventually live in the workflows repository.

@zachaysan zachaysan requested a review from a team as a code owner June 28, 2024 14:34
@zachaysan zachaysan requested review from khvn26 and removed request for a team June 28, 2024 14:34
Copy link

vercel bot commented Jun 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 1:45pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 1:45pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 1:45pm

@zachaysan zachaysan removed the request for review from khvn26 June 28, 2024 14:35
@github-actions github-actions bot added api Issue related to the REST API feature New feature or request labels Jun 28, 2024
Copy link
Contributor

github-actions bot commented Jun 28, 2024

Uffizzi Ephemeral Environment deployment-53620

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/4265

📄 View Application Logs etc.

What is Uffizzi? Learn more!

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 97.14286% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.79%. Comparing base (92daa88) to head (4f52f28).
Report is 12 commits behind head on main.

Files Patch % Lines
api/segments/models.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #4265    +/-   ##
========================================
  Coverage   96.78%   96.79%            
========================================
  Files        1159     1164     +5     
  Lines       38162    38272   +110     
========================================
+ Hits        36935    37044   +109     
- Misses       1227     1228     +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jul 1, 2024
@github-actions github-actions bot removed the feature New feature or request label Jul 17, 2024
Copy link
Contributor

github-actions bot commented Jul 17, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4265 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4265 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4265 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4265 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4265 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4265 Finished ✅ Results

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jul 17, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jul 17, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jul 18, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jul 18, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants