Remove MANAGE_USERS permission #1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uffizzi Preview |
matthewelwell
force-pushed
the
chore/remove-MANAGE_USERS-permission
branch
from
87ed675
to
e9b897c
Compare
gagantrivedi
approved these changes
Dec 15, 2022
gagantrivedi
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingChanges
Remove the MANAGE_USERS permission.
Reason: following a discussion with @kyle-ssg, this permission didn't really work at the organisation level, since the user would still be able to invite an organisation admin. We discussed removing the ability to invite organisation admin users, but then we were left with a user that would be able to invite a user but not really manage their permissions (unless they have permissions elsewhere) which just gets confusing and was not the original purpose of this permission.
Note: I'll need to remove the MANAGE_USERS permission from the staging database manually following this PR being merged.
How did you test this code?
Existing tests should cover this as I'm just removing functionality.