Improved binary support #2771
Merged
Improved binary support #2771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed fhir client: fun!
ewoutkramer
requested changes
Apr 16, 2024
ewoutkramer
approved these changes
Apr 23, 2024
|
also closes #1340 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added improved binary support for the FhirClient.
The FhirClient will attempt to request/recieve binary data instead of "Binary" resources where possible (these will still be parsed into resources upon receiving them, but it puts less stress on the network). If the server sends a resource nonetheless, the old implementation will handle this. This can be switched off in the settings (is on by default).
It is now also possible to send binary data, but far from all servers support this, so this will have to be turned on manually.
Related issues
Closes #2695
Testing
Integration test against firely and HAPI