Reorganize slicing helper functions (for R3) #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 7, 2021 09:42
Also, moved IncorrectElementDefinitionException to common. Also fixed all warnings emitted by the compiler.
marcovisserFurore
requested changes
Apr 7, 2021
src/Hl7.Fhir.Specification/Specification/Navigation/ElementNavigatorSlicingExtensions.cs
Outdated
Show resolved
Hide resolved
marcovisserFurore
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For the new validation compiler, I have rewritten (read: simplified) the code to detect (re)slices. I have moved this new code to this repo since it may be of use to others. There was some comparable (older) code that I have now either replaced (FindMemberSlices) or kept intact (variants of IsResliceOf) - to avoid introducing regressions.
Also, I have fixed some pre-existing compiler warnings.
FirelyTeam Checklist