Skip to content
This repository has been archived by the owner on Mar 25, 2024. It is now read-only.

Finish deprecation of all U2F-specific classes #36

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
Mark all traits as internal and deprecate ClientData
  • Loading branch information
Firehed committed Oct 27, 2021
commit 40eae4f0bca574a10ede9ab8aced69e2d3a46b61
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed
- Server's constructor now can take `string $appId` as a parameter
- WebAuthn\AuthenticatorData marked as internal
- All traits marked as internal

### Deprecated
- ChallengeProvider
Expand All @@ -31,6 +33,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- RegisterResponse (Replaced by WebAuthn/RegistrationResponse)
- SignRequest
- SignResponse (Replaced by WebAuthn/LoginResponse)
- ClientData (internal)


## [1.2.0] - 2021-10-26
Expand Down
3 changes: 3 additions & 0 deletions src/AppIdTrait.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@

namespace Firehed\U2F;

/**
* @internal
*/
trait AppIdTrait
{
/** @var string */
Expand Down
3 changes: 3 additions & 0 deletions src/ChallengeTrait.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

namespace Firehed\U2F;

/**
* @internal
*/
trait ChallengeTrait
{
/** @var string */
Expand Down
4 changes: 4 additions & 0 deletions src/ClientData.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@

use Firehed\U2F\InvalidDataException as IDE;

/**
* @deprecated
* @internal
*/
class ClientData
{
use ChallengeTrait;
Expand Down
3 changes: 3 additions & 0 deletions src/KeyHandleTrait.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

namespace Firehed\U2F;

/**
* @internal
*/
trait KeyHandleTrait
{
/** @var string (binary) */
Expand Down
3 changes: 3 additions & 0 deletions src/ResponseTrait.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@

use Firehed\U2F\InvalidDataException as IDE;

/**
* @internal
*/
trait ResponseTrait
{
use KeyHandleTrait;
Expand Down
3 changes: 3 additions & 0 deletions src/VersionTrait.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@

namespace Firehed\U2F;

/**
* @internal
*/
trait VersionTrait
{
/** @var 'U2F_V2' */
Expand Down
2 changes: 2 additions & 0 deletions src/WebAuthn/AuthenticatorData.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
use Firehed\CBOR\Decoder;

/**
* @internal
*
* @phpstan-type AttestedCredentialData array{
* aaguid: string,
* credentialId: string,
Expand Down