Skip to content
This repository has been archived by the owner on Mar 25, 2024. It is now read-only.

New server registration validation flow #30

Merged
merged 5 commits into from
Oct 26, 2021
Merged

Conversation

Firehed
Copy link
Owner

@Firehed Firehed commented Oct 26, 2021

This replaces $server->setRegisterRequest($request)->register($response) with $server->validateRegistration($request, $response)

@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #30 (a564f58) into master (d08126c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##              master       #30   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       134       135    +1     
===========================================
  Files             21        21           
  Lines            545       547    +2     
===========================================
+ Hits             545       547    +2     
Impacted Files Coverage Δ
src/Server.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d08126c...a564f58. Read the comment docs.

@Firehed Firehed marked this pull request as ready for review October 26, 2021 21:25
@Firehed Firehed merged commit 4b7c8c6 into master Oct 26, 2021
@Firehed Firehed deleted the validate-registration branch October 26, 2021 21:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant