Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework exceptions handling #20

Conversation

frantisekrokusek
Copy link

@frantisekrokusek frantisekrokusek commented Jun 13, 2022

Hello guys,

Sometimes you server sends unexpected errors.

I took the opportunity to rework your error handling to send more appropriate responses.

Bellow as there is no log_id AND there is no meta field, the gem returns a errors array that contains nil. In that case we loose the errors informations...

{
  "status"=>500, 
  "code"=>"[FILTERED]", 
  "errors"=>[
    {"code"=>"[FILTERED]", 
     "title"=>"Unknown Error", 
     "message"=>"An unknown error has been encountered. Please try again in a few moments."}
   ]
}

@Franciscorodr Franciscorodr merged commit 8783f19 into Fintecture:master Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants