Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow requesting payments with with_virtualbeneficiary parameter #22

Closed
bobmaerten opened this issue May 3, 2023 · 2 comments
Closed

Comments

@bobmaerten
Copy link
Contributor

In order to implement Reconciled transfer, it would be nice to have an optional parameter in the payments API as mentioned in https://doc.fintecture.com/docs/reconciled-transfer#payment-following-through-the-api

i.e.

# payments (session_id = nil, with_virtualbeneficiary: false)
#       session_id: string
#       with_virtualbeneficiary: boolean

response = pis_client.payments 
OR
response = pis_client.payments "7f47d3675f5d4964bc416b43af63b06e"
OR
response = pis_client.payments "7f47d3675f5d4964bc416b43af63b06e", with_virtualbeneficiary: true
xlaumonier-fintecture added a commit to xlaumonier-fintecture/fintecture-sdk-ruby that referenced this issue May 24, 2023
…rying payments with virtual beneficiary information
xlaumonier-fintecture added a commit that referenced this issue May 31, 2023
Fix #8 outdated documentation, feat #22 allow querying payments with virtual beneficiary information
@xlaumonier-fintecture
Copy link
Contributor

@bobmaerten Hello, we implemented the with_virtualbeneficiary parameter in latest 0.6.0 version (https://rubygems.org/gems/fintecture). Please let me know whether it all work as intended so I can close this ticket.

Have a good day,
XL

@bobmaerten
Copy link
Contributor Author

Works now as intended. 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants