Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to github.com/twpayne/go-pinentry-minimal #113

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

twpayne
Copy link
Contributor

@twpayne twpayne commented Jan 13, 2022

@FiloSottile
Copy link
Owner

The extra dependencies are a blocker, better pinentry support is not worth pulling in dependencies from three different organizations/authors. Are they necessary non-test dependencies of go-pinentry?

@twpayne
Copy link
Contributor Author

twpayne commented Jan 13, 2022

Are they necessary non-test dependencies of go-pinentry?

Nope, they're there for rich functionality, not necessary functionality. The core pinentry functionality only depends on the Go standard library.

Would you accept a version of go-pinentry that only has standard library dependencies?

@FiloSottile
Copy link
Owner

Yeah, it looks comparable in amount of complexity, if the gopasspw folks recommended it I'd be happy to switch.

@twpayne
Copy link
Contributor Author

twpayne commented Jan 13, 2022

OK, PR updated to use the minimal fork: https://github.com/twpayne/go-pinentry-minimal.

PTA(nother)L.

@twpayne twpayne changed the title Switch to github.com/twpayne/go-pinentry Switch to github.com/twpayne/go-pinentry-minimal Jan 13, 2022
@FiloSottile
Copy link
Owner

LGTM, thank you. Please drop the .gitignore commit, I generally prefer not to check in workflow-specific gitignores.

@twpayne
Copy link
Contributor Author

twpayne commented Jan 17, 2022

Please drop the .gitignore commit

Done.

@FiloSottile FiloSottile merged commit 205a7ef into FiloSottile:main Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants