Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/age-keygen: errorf calls os.exit #383

Merged
merged 1 commit into from
Jan 4, 2022
Merged

Conversation

vrnvu
Copy link
Contributor

@vrnvu vrnvu commented Jan 4, 2022

Shouldn't this function call os.exit as age errorf does?

func errorf(format string, v ...interface{}) {

@FiloSottile
Copy link
Owner

Ah, good catch. It looks like all errorf call sites would thankfully have led to a clean exit or a simple panic if skipped (and not, say, generating an invalid key), so at least it's not a security vulnerability.

@FiloSottile FiloSottile merged commit 4169274 into FiloSottile:main Jan 4, 2022
@FiloSottile
Copy link
Owner

Introduced in v1.0.0-rc.3 by 0703f86.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants