refactor(routes): use String.slice() over String.substring()

Fdawgs · Oct 1, 2023 · 2c5517c · 2c5517c
1 parent e00b708
commit 2c5517c
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 15 deletions.
diff --git a/src/routes/admin/access/bearer-token/index.js b/src/routes/admin/access/bearer-token/index.js
@@ -216,11 +216,11 @@ async function route(server, options) {
  expires.forEach((expiryDate) => {
  let date = expiryDate;
  const operator = server.convertDateParamOperator(
- date.substring(0, 2)
+ date.slice(0, 2)
  );
 
- if (Number.isNaN(Number(date.substring(0, 2)))) {
- date = date.substring(2, date.length);
+ if (Number.isNaN(Number(date.slice(0, 2)))) {
+ date = date.slice(2);
  }
 
  whereArray.push(escSq`(expires ${operator} '${date}')`);
@@ -239,11 +239,11 @@ async function route(server, options) {
  created.forEach((createDate) => {
  let date = createDate;
  const operator = server.convertDateParamOperator(
- date.substring(0, 2)
+ date.slice(0, 2)
  );
 
- if (Number.isNaN(Number(date.substring(0, 2)))) {
- date = date.substring(2, date.length);
+ if (Number.isNaN(Number(date.slice(0, 2)))) {
+ date = date.slice(2);
  }
 
  whereArray.push(escSq`(created ${operator} '${date}')`);
@@ -264,11 +264,11 @@ async function route(server, options) {
  lastUpdated.forEach((lastUpdatedDate) => {
  let date = lastUpdatedDate;
  const operator = server.convertDateParamOperator(
- date.substring(0, 2)
+ date.slice(0, 2)
  );
 
- if (Number.isNaN(Number(date.substring(0, 2)))) {
- date = date.substring(2, date.length);
+ if (Number.isNaN(Number(date.slice(0, 2)))) {
+ date = date.slice(2);
  }
 
  whereArray.push(

diff --git a/src/routes/contact/index.js b/src/routes/contact/index.js
@@ -268,11 +268,11 @@ async function route(server, options) {
  created.forEach((createDate) => {
  let date = createDate;
  const operator = server.convertDateParamOperator(
- date.substring(0, 2)
+ date.slice(0, 2)
  );
 
- if (Number.isNaN(Number(date.substring(0, 2)))) {
- date = date.substring(2, date.length);
+ if (Number.isNaN(Number(date.slice(0, 2)))) {
+ date = date.slice(2);
  }
 
  whereArray.push(escSq`(created ${operator} '${date}')`);
@@ -293,11 +293,11 @@ async function route(server, options) {
  lastUpdated.forEach((lastUpdatedDate) => {
  let date = lastUpdatedDate;
  const operator = server.convertDateParamOperator(
- date.substring(0, 2)
+ date.slice(0, 2)
  );
 
- if (Number.isNaN(Number(date.substring(0, 2)))) {
- date = date.substring(2, date.length);
+ if (Number.isNaN(Number(date.slice(0, 2)))) {
+ date = date.slice(2);
  }
 
  whereArray.push(