Update Program.cs

Added exception handling in CreateOutput function (when parsing adobjects)
FalconForceTeam · Feb 1, 2024 · 818a0b5 · 818a0b5
1 parent cd2fc63
commit 818a0b5
Showing 1 changed file with 60 additions and 53 deletions.
diff --git a/Program.cs b/Program.cs
@@ -559,62 +559,69 @@ public void CreateOutput(List<ADObject> adobjects, string header)
  OutputContainers outputContainers = new OutputContainers();
 
  foreach (ADObject adobject in adobjects)
- {
- if (adobject.Class == "computer")
- {
- ComputerProcessor _comp = new ComputerProcessor();
- ComputerNode computerNode = _comp.parseComputerObject(adobject, domainName);
- outputComputers.data.Add(computerNode);
- }
- else if (adobject.Class == "user")
- {
- UserProcessor _usr = new UserProcessor();
- UserNode userNode = _usr.parseUserObject(adobject, domainName);
- outputUsers.data.Add(userNode);
- }
- else if (adobject.Class == "group")
- {
- GroupProcessor _grp = new GroupProcessor();
- GroupNode groupNode = _grp.parseGroupObject(adobject, domainName);
- outputGroups.data.Add(groupNode);
-
- }
- else if (adobject.Class == "domaindns" || adobject.Class == "domain")
- {
- DomainProcessor _dom = new DomainProcessor(Server, Port, Credential);
- DomainNode domainNode = _dom.parseDomainObject(adobject);
- outputDomains.data.Add(domainNode);
- }
- else if (adobject.Class == "grouppolicycontainer")
- {
- GPOProcessor _gpo = new GPOProcessor();
- GPONode gpoNode = _gpo.parseGPOObject(adobject, domainName);
- outputGPOs.data.Add(gpoNode);
- }
- else if (adobject.Class == "organizationalunit")
- {
- OUProcessor _ou = new OUProcessor();
- OUNode ouNode = _ou.parseOUObject(adobject, domainName);
- outputOUs.data.Add(ouNode);
- }
- else if (adobject.Class == "container" || adobject.Class == "rpccontainer" || adobject.Class == "msimaging-psps" || adobject.Class == "msExchConfigurationContainer") //todo: add more custom container classes
+ { 
+ try
  {
- //filter out domainupdates and user/machine system policies
- string dn = adobject.DistinguishedName.ToUpper();
- if (dn.Contains("CN=DOMAINUPDATES,CN=SYSTEM"))
- continue;
- if (dn.Contains("CN=POLICIES,CN=SYSTEM") && (dn.StartsWith("CN=USER") || dn.StartsWith("CN=MACHINE")))
- continue;
-
- ContainerProcessor _cp = new ContainerProcessor();
- ContainerNode containerNode = _cp.parseContainerObject(adobject, domainName);
- outputContainers.data.Add(containerNode);
+ if (adobject.Class == "computer")
+ {
+ ComputerProcessor _comp = new ComputerProcessor();
+ ComputerNode computerNode = _comp.parseComputerObject(adobject, domainName);
+ outputComputers.data.Add(computerNode);
+ }
+ else if (adobject.Class == "user")
+ {
+ UserProcessor _usr = new UserProcessor();
+ UserNode userNode = _usr.parseUserObject(adobject, domainName);
+ outputUsers.data.Add(userNode);
+ }
+ else if (adobject.Class == "group")
+ {
+ GroupProcessor _grp = new GroupProcessor();
+ GroupNode groupNode = _grp.parseGroupObject(adobject, domainName);
+ outputGroups.data.Add(groupNode);
+
+ }
+ else if (adobject.Class == "domaindns" || adobject.Class == "domain")
+ {
+ DomainProcessor _dom = new DomainProcessor(Server, Port, Credential);
+ DomainNode domainNode = _dom.parseDomainObject(adobject);
+ outputDomains.data.Add(domainNode);
+ }
+ else if (adobject.Class == "grouppolicycontainer")
+ {
+ GPOProcessor _gpo = new GPOProcessor();
+ GPONode gpoNode = _gpo.parseGPOObject(adobject, domainName);
+ outputGPOs.data.Add(gpoNode);
+ }
+ else if (adobject.Class == "organizationalunit")
+ {
+ OUProcessor _ou = new OUProcessor();
+ OUNode ouNode = _ou.parseOUObject(adobject, domainName);
+ outputOUs.data.Add(ouNode);
+ }
+ else if (adobject.Class == "container" || adobject.Class == "rpccontainer" || adobject.Class == "msimaging-psps" || adobject.Class == "msExchConfigurationContainer") //todo: add more custom container classes
+ {
+ //filter out domainupdates and user/machine system policies
+ string dn = adobject.DistinguishedName.ToUpper();
+ if (dn.Contains("CN=DOMAINUPDATES,CN=SYSTEM"))
+ continue;
+ if (dn.Contains("CN=POLICIES,CN=SYSTEM") && (dn.StartsWith("CN=USER") || dn.StartsWith("CN=MACHINE")))
+ continue;
+
+ ContainerProcessor _cp = new ContainerProcessor();
+ ContainerNode containerNode = _cp.parseContainerObject(adobject, domainName);
+ outputContainers.data.Add(containerNode);
+ }
+ else
+ {
+
+ //Trace.WriteLine("we have an unprocessed " + adobject.Class + " object:" + adobject.Name);
+ }
  }
- else
+ catch (Exception e)
  {
-
- //Trace.WriteLine("we have an unprocessed " + adobject.Class + " object:" + adobject.Name);
- }
+ DisplayErrorMessage("Exception " + e.ToString() + "\nError parsing object with ObjectGUID :" + adobject.ObjectGUID.ToString());
+ } 
  }
  outputUsers.meta.count = outputUsers.data.Count();
  if (outputUsers.meta.count > 0)