Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prep for 4.2.0 release and helm chart update #643

Merged
merged 2 commits into from
Sep 28, 2021
Merged

prep for 4.2.0 release and helm chart update #643

merged 2 commits into from
Sep 28, 2021

Conversation

lucasreed
Copy link
Contributor

No description provided.

lucasreed
lucasreed commented Sep 28, 2021
View reviewed changes
main.go
@@ -15,12 +15,12 @@
package main

import (
"github.com/fairwindsops/polaris/cmd/polaris"
cmd "github.com/fairwindsops/polaris/cmd/polaris"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My editor kept wanting to change this so even though the module at that directory is named cmd this makes the below code more clear I think.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

rbren
rbren approved these changes Sep 28, 2021
View reviewed changes
main.go
@@ -15,12 +15,12 @@
package main

import (
"github.com/fairwindsops/polaris/cmd/polaris"
cmd "github.com/fairwindsops/polaris/cmd/polaris"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

rbren
rbren reviewed Sep 28, 2021
View reviewed changes
Copy link
Contributor

@rbren rbren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh - README.md needs the new version too

@rbren
Copy link
Contributor

rbren commented Sep 28, 2021 •
edited
Loading

Also if you wouldn't mind updating docs/changelog.md

@lucasreed lucasreed merged commit c398f10 into master Sep 28, 2021
@lucasreed lucasreed deleted the lr/update_polaris branch September 28, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbren rbren rbren approved these changes

@makoscafee makoscafee Awaiting requested review from makoscafee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lucasreed @rbren