Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pack config.yaml in Docker #298

Merged
merged 2 commits into from
May 18, 2020
Merged

Pack config.yaml in Docker #298

merged 2 commits into from
May 18, 2020

Conversation

rbren
Copy link
Contributor

@rbren rbren commented May 18, 2020

No description provided.

@codecov
Copy link

codecov bot commented May 18, 2020

Codecov Report

Merging #298 into master will decrease coverage by 0.21%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #298      +/-   ##
==========================================
- Coverage   51.35%   51.13%   -0.22%     
==========================================
  Files          12       12              
  Lines         699      702       +3     
==========================================
  Hits          359      359              
- Misses        293      296       +3     
  Partials       47       47              
Impacted Files Coverage Δ
pkg/config/config.go 61.76% <0.00%> (-5.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b557786...1c96a5b. Read the comment docs.

Copy link
Contributor

@makoscafee makoscafee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. are those exemptions not used any more?

@rbren rbren merged commit 9d81c39 into master May 18, 2020
@rbren rbren deleted the rb/pack-config branch May 18, 2020 21:16
@rbren
Copy link
Contributor Author

rbren commented May 18, 2020

I decided to remove the exemptions from config-full.yaml, since they're constantly falling out of date.

config-full.yaml is really an example usage, but probably wouldn't be dropped in for anyone. config.yaml is the default though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants