Add type definitions for compatibility with typescript projects #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looking good! @IanEdington Do you think is important to retain the history of the types too from the origin?
IanEdington
reviewed
Sep 23, 2022
package.json
Outdated
| @@ -58,5 +60,6 @@ | |||
| "dependencies": { | |||
| "color": "^3.1.3", | |||
| "react-reconciler": "^0.26.1" | |||
| } | |||
| }, | |||
| "types": "types/index.d.ts" | |||
There was a problem hiding this comment.
Could we move this to the top of this file close to the main / files members?
IanEdington
reviewed
Sep 23, 2022
Since we'll be replacing this anyways and it's a not core to the logic of the components I don't think the effort is worth it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.