Update build tools for mjml-react and release the first version #1
Conversation
package.json
Outdated
| ] | ||
| } | ||
| "dependencies": { | ||
| "color": "^3.1.3" |
There was a problem hiding this comment.
Is this a true dependency? As in it's needed by all instances of mjml-react in order to work properly in someone elses build?
There was a problem hiding this comment.
Yes it is a dependency. There is a script that relies on color import. We can clean up this in the future but let's keep it as close to the existing release as possible
There was a problem hiding this comment.
If it's a script that isn't exported in the npm bin we can probably make it dev only
There was a problem hiding this comment.
It is exported in index.js
export { render, renderToMjml, renderToJSON, renderToJSON2 };
renderToJSON is the consumer
package.json
Outdated
| "mjml2json": "^1.0.1", | ||
| "prop-types": "^15.8.1", | ||
| "react": "^17.0.0", | ||
| "react-dom": "^17.0.0", | ||
| "react-reconciler": "^0.26.1" |
There was a problem hiding this comment.
Is "react-reconciler" needed as a peer dependency? It looks like it used to be a dependency
There was a problem hiding this comment.
I just put back to wherever it should belong in the previous version of package.json
| registry=https://registry.npmjs.org/ | ||
| always-auth=true |
There was a problem hiding this comment.
I think this will need to be removed when other people start working on the project, but that can be tackled at a different time.
There was a problem hiding this comment.
Sounds good, let's revisit this in the future
No description provided.