Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add canvas feature #67

Merged
merged 9 commits into from
May 2, 2024
Merged

Add canvas feature #67

merged 9 commits into from
May 2, 2024

Conversation

dientuki
Copy link
Contributor

@dientuki dientuki commented May 1, 2024

No description provided.

@Fabrizz
Copy link
Owner

Fabrizz commented May 1, 2024

Hola, esta feature es genial, voy a cambiarle el nombre a experimentalCanvas, como experimentalCode, que son APIs no documentadas. Tengo que leer bien la PR. De todas formas obtengo un error al iniciar el modulo:

image

@Fabrizz
Copy link
Owner

Fabrizz commented May 2, 2024

Ahí lo fixié y lo hice que la llamada sea stateless, la verdad que queda genial, (Y no se como no había pensado lo de cargar las imágenes de esa forma). Después lo pusheo a esta PR

image

@Fabrizz Fabrizz changed the base branch from master to dev-features May 2, 2024 18:16
@Fabrizz Fabrizz changed the base branch from dev-features to canva-feature May 2, 2024 18:17
@Fabrizz
Copy link
Owner

Fabrizz commented May 2, 2024

Esta genial, ahí escribo la release y el readme

@Fabrizz Fabrizz merged commit a95734c into Fabrizz:canva-feature May 2, 2024
@dientuki
Copy link
Contributor Author

dientuki commented May 2, 2024

Joya! algo de la documentacion habia escrito

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants