Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finding a reason of server crash on the online change #424

Closed
wants to merge 4 commits into from

Conversation

d47081
Copy link

@d47081 d47081 commented Jan 13, 2024

After enabling dynamical add/remove bots on online change (by min/max settings), found an issue - server crashes sometimes. It mostly happened when more than one players online

With permanent quantity of bots is no problems

As commented in code, there is could be timeout reason.

Please do not merge this PR until testing on YGGverse server will be completed.
But this one commit would be included here.

@a1batross
Copy link
Member

a1batross commented Jan 13, 2024

Try to run engine with sanitizers enabled (It's -T sanitize option in waf configure) and with debugger attached. Also enable verbose logging in engine, it's -dev 2 flag to Xash.

@a1batross
Copy link
Member

It might as well be the bug in the engine. =/

@d47081
Copy link
Author

d47081 commented Jan 13, 2024

By the way, maybe I forgot to add respawn_time = gpGlobals->time + 1.0; in PR #422

This reason is deeper anyway, some issues with memory going as bots started to respawn with random params and ignore configuration.

It works for some time but later something happened, it looks like memory control issues. Probably in the engine - will try to recompile, thanks for advice

dlls/client.cpp Outdated Show resolved Hide resolved
@nekonomicon nekonomicon self-requested a review January 13, 2024 04:06
@d47081
Copy link
Author

d47081 commented Jan 13, 2024

I've also added missed timing delay 09c481f

Suppose that will fix the problem as is, let me test for some time

@d47081
Copy link
Author

d47081 commented Jan 13, 2024

I have returned integer value for timeout offset, another values could be optimized by another PR.

Server get crashed few hours before, no relation with players / max online / min bots quantity

image

Running server with -dev 2 to catch more info..
Suppose it also could be related with map rotate event - when some players exists, but gone and bot can't respawn

@d47081
Copy link
Author

d47081 commented Jan 14, 2024

Closing this PR as important changes included in #426

This branch could require lot of manual resolving on finally merge.

@d47081 d47081 closed this Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants