Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARMv8 neon support for studio util #379

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Conversation

MoeMod
Copy link
Contributor

@MoeMod MoeMod commented Jun 12, 2023

No description provided.

@a1batross
Copy link
Member

Does it make any difference?

Of course, compared with release build.

@MoeMod
Copy link
Contributor Author

MoeMod commented Jun 12, 2023

Does it make any difference?

Of course, compared with release build.

I found that AngleQuaternion and QuaternionSlerp takes 30%+ cpu time in multiplayer CS, so in such scenario it may save some performance.

@a1batross
Copy link
Member

a1batross commented Jun 12, 2023 via email

@nekonomicon
Copy link
Member

BTW may be use SSE version(useful for x86 and e2k) + SIMD everywhere?
It can give performance boost on many architectures.

@a1batross
Copy link
Member

@nekonomicon it would be nice to at least start with ARM.

@MoeMod
Copy link
Contributor Author

MoeMod commented Jun 21, 2023

BTW may be use SSE version(useful for x86 and e2k) + SIMD everywhere?
It can give performance boost on many architectures.

I have implemented some function with SSE, but didn't get significant performance boost on PC. That's too much redundant work to work on double platforms, so I am working on only arm64 now.

Copy link
Member

@a1batross a1batross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mostly approve. Maybe it only needs slight reformatting to be in line with the other SDK code.

Adding a separate SSE variant is out of the scope of this PR.

@nekonomicon nekonomicon merged commit 69f27d4 into FWGS:master Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants