build: fix travis ci #108
Merged
build: fix travis ci #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think travis is still using Python 3.4.*, so f-strings are not supported yet and android engine doesn't build.
a1batross
reviewed
Oct 31, 2019
dlls/wscript
Outdated
| @@ -16,7 +16,7 @@ def configure(conf): | |||
| hlDefNode = conf.path.find_resource("./hl.def") | |||
|
|
|||
| if hlDefNode is not None: | |||
| conf.env.append_unique('LINKFLAGS', f'/def:{hlDefNode.abspath()}') | |||
| conf.env.append_unique('LINKFLAGS', '/def:{}'.format(hlDefNode.abspath())) | |||
There was a problem hiding this comment.
Let's then use % notation, i.e. '/def:%s' % hlDefNode.abspath(), it's shorter and easier to read, IMO.
There was a problem hiding this comment.
As you wish, I'm not a huge fan of C style formatting in Python :)
There was a problem hiding this comment.
Fan or not fan, but even python programmers on my main job uses this style.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think travis is still using Python 3.4.*, so f-strings are not supported yet and android engine doesn't build.