Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Swapped Win32 check for MSVC check #107

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Build: Swapped Win32 check for MSVC check #107

merged 1 commit into from
Oct 31, 2019

Conversation

noodlecollie
Copy link
Contributor

@mittorn commented that technically I should have been checking against the compiler rather than the target OS, since /def is a MSVC-specific flag.

Build: Swapped Win32 check for MSVC check
a866945 
The linker flag is only relevant to MSVC.
@a1batross
Copy link
Member

Oops, didn't noticed it.

Should we also have same flag for CMake as well?

@a1batross a1batross merged commit 576e6be into FWGS:master Oct 31, 2019
@noodlecollie
Copy link
Contributor Author

I think CMake should already work, since it did for me before I switched to Waf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noodlecollie @a1batross