Skip to content
This repository has been archived by the owner on Sep 24, 2022. It is now read-only.

Buffer management #5

Merged
merged 1 commit into from
Aug 1, 2011
Merged

Buffer management #5

merged 1 commit into from
Aug 1, 2011

Conversation

vmg
Copy link
Contributor

@vmg vmg commented Aug 1, 2011

Sup bro,

your buffer allocation was broken and leaking memory. This will be much faster for larger documents, since the source is now static and we don't duplicate after Smartypants.

Cheers

@FSX
Copy link
Owner

FSX commented Aug 1, 2011

Cool, thanks.

I have a question if you don't mind. Shouldn't ib be cleaned up with bufrelease?

@vmg
Copy link
Contributor Author

vmg commented Aug 1, 2011

No, not really. ib is declared statically, and ib->data is a borrowed reference to the Python string, so Python itself will take care of cleaning up the mess.

@FSX
Copy link
Owner

FSX commented Aug 1, 2011

I see. Thanks for explaining. I have to learn more C.

FSX added a commit that referenced this pull request Aug 1, 2011
Buffer management has been fixed by tanoku.
@FSX FSX merged commit df07b91 into FSX:master Aug 1, 2011
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants