Fix for building with Visual Studio 2008 Express #15
Conversation
…ecise) I needed to add 1 define in 3 files, betweend #if defined(_WIN32) guards : - #define strncasecmp _strnicmp - #define snprintf _snprintf
|
Before applying this patch, I also needed to complete Visual Studio 2008 SDK with a missing "stdint.h" : Perhaps shall I also make a workaround for this ? |
|
You should send this pull request to the Sundown repository, because I update the Sundown files with a git submodule. There are already 2 people (I think) who did that and it's still not merged in Sundown. Maybe I'll created a temporary fork and merge your changed in there. |
|
Yes, I've made a pull request to the upstream Sundown project Thank you |
|
Looks like @SRombauts pull request was just merged. If you update to the latest version of sundown, I'll test on my Windows machine too. |
|
I have updated the Sundown files. |
|
Thank you - I can confirm that it builds on Windows now. Most Visual Studio compilers don't include stdint.h (except VS2010), so you can download a third-party one and put it in the include directory. I use this one: http:https://msinttypes.googlecode.com/svn/trunk/stdint.h After that, running |
|
Where in the include directory in Window/Visual Studio? I can put it in the installation instructions. |
|
I installed Visual Studio at |
|
Ok, added. 032ca13 |
|
Awesome, thanks! |
|
Thanks, this way you've mostly fixed @Anomareh/mynt under Windows :) |
Fix for building with Visual Studio 2008 Express (link error to be precise)
markdown.obj : error LNK2019: unresolved external symbol _strncasecmp referenced in function _find_block_tag
autolink.obj : error LNK2001: unresolved external symbol _strncasecmp
html_smartypants.obj : error LNK2019: unresolved external symbol _snprintf referenced in function _smartypants_quotes
I needed to add 1 define in 3 files, betweend #if defined(_WIN32) guards :