Gh actions #9
Open
Gh actions #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addendum to 65fd292. CORE-16700
In current implementation, when regedit opens HKCR root key, an error is logged err:(dll/win32/advapi32/reg/hkcr.c:964) Returning 259. This is not correct as the code 259 is ERROR_NO_MORE_ITEMS which is the nominal return value when end of enumeration is reached.
- When exporting registry keys (to .reg files) some variables from the heap are not free'd while the debug log indicates "HEAP: Trying to free an invalid address". - This is due to the export_registry_key() function that calls HeapFree() for reg_key_name. But this variable is an argument provided by the caller, which is always a statically defined array of WCHAR. - Meanwhile reg_key_name_buf is never free'd and cause a memory leak each time the function gets called.
Distinguish floppy drive and non-floppy removable drive in icon and description. CORE-10221
- Improved logic of the text - Removed some line breaks to improve readability on some screen sizes
This prevents ReactOS asserting when 'My computer' is opened, while it tries to send commands to floppy drive. Many thanks to patches author Doug Lyons. The regression was introduced by 0.4.13-dev-1081-g eeff926 patch was committed to 0.4.13rls and 0.4.14rls as well. Today it was committed to master as well, as the initially planned investigation for the root cause did still not happen and we can not afford the time to retest and workaround this over and over again. Thank god that Oleg Dubinskiy was still around to retest this again and confirmed it can still happen, because unlike initially, personally I was not able to reproduce it today anymore! Since every release was work-arounded, we did never expose the bug in any final release.
…s#2711) Co-Authored-By: Vadim Galyant <[email protected]>
Change SetWindowLongW to SetWindowLongPtrW. It's the same (because the value is 0) but I think it's better.
## Purpose [SYSDM] - When closing System Properties page, log show (win32ss/user/ntuser/windc.c:749) err: [00060138] GetDC() without ReleaseDC()! because GetDC() is called (multiple times) without properly calling ReleaseDC() as required in order to release a device context. - This module also lacks some error management in case null DC are provided (on error). - LiveCD Userinit, based on SYSDM is affected too. [DESK] - Fix missing ReleaseDC related to the spectrum (color depth) ## Proposed changes - ReleaseDC() added. - Error management in case of null DC. - Overall alignement of LiveCD Userinit and SYSDM.
(Supersedes PR reactos#2374.) CORE-16707
…reactos#2743) In addition to that, add the missing function prototypes in the DLL dialog header of Utilman, add missing IN/OUT annotations and remove CheckUtilityState() prototype which is barely used (it's not implemented either).
reactos#2753) This reverts commit 2d4d3f5. Reverts reactos#2146. I think reactos#2135 (e329e83) and reactos#2146 (2d4d3f5) are my mistakes. CORE-16552, CORE-16747
…os#2146)" (reactos#2753)" (reactos#2758) This reverts commit 66b0a48.
Remove "Opaque" parameter so that the transparency can be correctly used.
Remove WM_SYSKEYDOWN handling at component level, in consistency with other components (ListView,...) Early embodiement of the fix proposed to WineHQ : https://bugs.winehq.org/show_bug.cgi?id=49097 in order to remove functionnal limitation in ReactOS. CORE-17020
…alog. (reactos#2732) Add Recent Documents and My Network Places to the places bar in the open file dialog. NOTE: Technically this "places bar" can be customized: https://www.tenforums.com/tutorials/126153-change-places-bar-items-common-dialog-box-windows.html https://www.sevenforums.com/tutorials/85487-common-file-dialog-box-customize-places-bar.html
…there is no volume mounted (reactos#2703) Return ERROR_INVALID_DRIVE if the drive is either unknown or unmounted.
This fixes a bugcheck in ntoskrnl.exe when computer has multiple ISA buses. CORE-17034
… CORE-14683 This version (after .rsrc) works different than the proper version I used for 0.4.12 (after .reloc). Inserting after .rsrc is actually not correct, but Thomas believes it can be used as a temporary trick to avoid random memory corruption upon relocations of the kernel, caused by ROSBE-154. I follow his advice, although when judging from practical tests only: as long as we limit this script to NTOSKRNL like I do for releases there have no negative consequences been observed in real life yet even with the proper version of 0.4.12. Up to now those problems have only been observed when used for drivers MODULE TYPE sdk/cmake/gcc.cmake as well, like it was tried for a moment in master 0.4.13-dev-609-g c4d8e2a Using for drivers immediately did lead to BSODs like CORE-16183 and therefore was mitigated in master by total disabling of the scripts for both, kernel and drivers in 0.4.13-dev-621-g 36e9a6f To allow installing DVDWritenow without BSOD, we need the script at least for ntoskrnl! I committed this patch (after .rsrc) already into 0.4.13RC and 0.4.14RC.
Implement shlwapi!SHIsLowMemoryMachine function.
…2723) - Comment some other missing exports Windows regapi.dll has them, but Wine's one doesn't. Required by MS winlogon with Win32SS replaced. I double-rechecked: now it doesn't fail due to missing regapi.dll in system32 or separate missing functions in this dll, exactly the same as with MS regapi. In pair with my profmap.dll (which was merged recently), now it fails due to InitializeUserProfile() stub in our userenv.dll (if to replace msgina too). Also I compared the exports of MS regapi.dll and Wine's one. Win2k3 version has all exports that Wine version has and some others (which looks like were dropped in NT6). But those exports which already exist, are enough to allow MS winlogon no longer fail. CORE-16458
* [TRANSLATIONS] Translate desk.cpl to Turkish * Update file header * [TRANSLATIONS] * Update translations of syssteup * Update translations of userenv * Update translations of shell32 (partial) * [TRANSLATION] Fix a translation * [TRANSLATION] Translate Turkish strings to Turkish for hivedef.inf * Update Turkish translations of shell32 partially * Update shell32 Turkish translations (partially) * Update shell32 Turkish translations (partially) * Fix translation for desk.cpl
As the dialog simply displays the copyright names and nothing particular it makes sense to use ShellAboutW() instead.
- Fixed invisible text in DIALOGS.
If the registry key that holds the names of installed opengl drivers is missing, all list boxes in openglcfg are empty. This is a minor code rearrangement to fix this behavior. Co-authored-by: Hermès BÉLUSCA - MAÏTO <[email protected]>
Implement shell32!MakeShellURLFromPathA function.
Implement shell32!SheShortenPathA function.
- Avoid buffer overrun. - Don't hardcode C: drive. CORE-13235
…eactos#1132) - Add getsockname() addr_con_loc looping case. Fix intermittent failure on Windows (NT <= 6.0): "WSAAsync.c:232: Test failed: ERROR: getsockname function wrong addr, expected 100007f returned 0" ROSTESTS-317 - Improve select() ServerSocket looping case. Visible on Windows (NT >= 6.1).
…os#1818) During initialization of property sheet dialogs, their overall size can change (when adding property sheets) after the dialog has been created and pre-positioned by win32k. Therefore their position needs to be recomputed so that they try to fit the best on screen. CORE-9008, CORE-9602
With the minimum Visual Studio version now being 2015, we no longer need to maintain two variants of the same code, and can stick to the commented and better understandable version.
Return value was a suggestion from Thomas, it still boots for me (tm)
…ct display after edit, WM_NOTIFY refactor) (reactos#2733) * - Fix of missing invalid handle check - Fix of Address & status bar incorrect display after rename - Refactoring of Treeview WM_NOTIFY code, for better consistency with WM_NOTIFY management for ListView * Fix following review (space in #define) * Cleanup following review * fix following review * Fix of round 3 of review comments * UpdateAdress kept in its original location * fix * fix (extern missing) * both extern removed * Review comments Error message being added in order to support CORE-17048
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Do a quick recap of your work here.
JIRA issue: CORE-XXXX
Proposed changes
Describe what you propose to change/add/fix with this pull request.
TODO
Use a TODO when your pull request is Work in Progress.